Add version check for cached AOT contracts. #981
+35
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azteca1998
requested review from
edg-l,
igaray,
jrchatruc,
entropidelic,
fmoletta,
Oppen,
pefontana and
gabrielbosio
as code owners
|
Benchmark results Main vs HEAD.
|
Benchmarking resultsBenchmark for program
|
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.134 ± 0.088 | 13.980 | 14.274 | 10.46 ± 0.08 |
cairo-native (embedded AOT) |
4.263 ± 0.028 | 4.231 | 4.320 | 3.15 ± 0.02 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
4.263 ± 0.072 | 4.134 | 4.370 | 3.15 ± 0.06 |
cairo-native (standalone AOT with -march=native) |
1.352 ± 0.006 | 1.347 | 1.369 | 1.00 |
Benchmark for program fib_2M
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
14.720 ± 0.195 | 14.387 | 15.012 | 188.33 ± 2.52 |
cairo-native (embedded AOT) |
4.015 ± 0.081 | 3.901 | 4.133 | 51.37 ± 1.04 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.810 ± 0.039 | 3.745 | 3.857 | 48.74 ± 0.51 |
cairo-native (standalone AOT with -march=native) |
0.078 ± 0.000 | 0.078 | 0.079 | 1.00 |
Benchmark for program linear_search
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.683 ± 0.040 | 5.616 | 5.757 | 2857.57 ± 63.35 |
cairo-native (embedded AOT) |
3.921 ± 0.036 | 3.883 | 3.996 | 1971.53 ± 45.12 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.802 ± 0.016 | 3.780 | 3.832 | 1911.62 ± 40.95 |
cairo-native (standalone AOT with -march=native) |
0.002 ± 0.000 | 0.002 | 0.002 | 1.00 |
Benchmark for program logistic_map
Open benchmarks
| Command | Mean [s] | Min [s] | Max [s] | Relative |
|---|---|---|---|---|
Cairo-vm (Rust, Cairo 1) |
5.633 ± 0.038 | 5.576 | 5.704 | 23.25 ± 0.16 |
cairo-native (embedded AOT) |
4.048 ± 0.066 | 3.951 | 4.170 | 16.70 ± 0.27 |
cairo-native (embedded JIT using LLVM's ORC Engine) |
3.999 ± 0.042 | 3.920 | 4.045 | 16.50 ± 0.18 |
cairo-native (standalone AOT with -march=native) |
0.242 ± 0.001 | 0.242 | 0.243 | 1.00 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
==========================================
- Coverage 80.76% 80.72% -0.05%
==========================================
Files 107 107
Lines 29256 29267 +11
==========================================
- Hits 23628 23625 -3
- Misses 5628 5642 +14 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now it'll panic with an assert. It is the user's responsibility to clear the contract cache when upgrading.
Checklist